Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

latest sync with brave branch chrome version 130 #87

Merged
merged 4,149 commits into from
Nov 10, 2024
Merged

latest sync with brave branch chrome version 130 #87

merged 4,149 commits into from
Nov 10, 2024

Conversation

udaybansal19
Copy link
Collaborator

No description provided.

simonhong and others added 30 commits October 11, 2024 16:18
issue: brave/brave-browser#41543

For testing one-shot leo panel open, template url service should
be loaded in advance.
…ngling-access

[DanglingPtr] Fix `AdBlockPrefService` dangling access
* Fixed navigation bar color at private tab; fixes brave/brave-browser#41545

Chromium change:
https://source.chromium.org/chromium/chromium/src/+/52962da478ed750038f966c386c4ee0ff2d73837

Always apply luminance calculation to navigation bar icons

Currently, the navigation bar icons only respond to the color of the navigation bar during animations. Since animations are being disabled for the navbar coloring experiment, it's important that the luminance calculation to properly color the navigation bar icons is applied all the time, not just during animations.

Bug: 364228106, 40925025
This change fixes violations on a few tests by:

  - Correcting creation order
  - Using factory types directly, rather than storing a pointer.
There has been crashes relating to `ViewCounterService` pointers held by
`NTPBackgroundImagesService` ending up dangling over the observer not
being removed.

This change adds a `ScopedObservation` as this makes the whole flow more
tight, and safer.
…-tabs-setting-placement

Fix placement of inactive tabs setting
…-in-page-headers

style(wallet): Remove Divider in Page Headers
…uses.

The assets generated now include all of the Brave group policies in a group
called "BraveSoftware".

Fixes brave/brave-browser#26502
Make Brave-specific options configurable through Windows Group Policy templates
[Rewards 3.0] Fix Default AC amount display
* AI Chat: display line breaks in human messages

- use white-space: pre-wrap to preserve indentations
- add indentation example
[Toggle]: Fix toggles not toggling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment