forked from brave/brave-core
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
latest sync with brave branch chrome version 130 #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
issue: brave/brave-browser#41543 For testing one-shot leo panel open, template url service should be loaded in advance.
…ngling-access [DanglingPtr] Fix `AdBlockPrefService` dangling access
Fixed flaky sidebar browser test
* Fixed navigation bar color at private tab; fixes brave/brave-browser#41545 Chromium change: https://source.chromium.org/chromium/chromium/src/+/52962da478ed750038f966c386c4ee0ff2d73837 Always apply luminance calculation to navigation bar icons Currently, the navigation bar icons only respond to the color of the navigation bar during animations. Since animations are being disabled for the navbar coloring experiment, it's important that the luminance calculation to properly color the navigation bar icons is applied all the time, not just during animations. Bug: 364228106, 40925025
This change fixes violations on a few tests by: - Correcting creation order - Using factory types directly, rather than storing a pointer.
There has been crashes relating to `ViewCounterService` pointers held by `NTPBackgroundImagesService` ending up dangling over the observer not being removed. This change adds a `ScopedObservation` as this makes the whole flow more tight, and safer.
…-tabs-setting-placement Fix placement of inactive tabs setting
…-in-page-headers style(wallet): Remove Divider in Page Headers
…uses. The assets generated now include all of the Brave group policies in a group called "BraveSoftware". Fixes brave/brave-browser#26502
Co-authored-by: Michael Herrmann <[email protected]>
Co-authored-by: Michael Herrmann <[email protected]>
Make Brave-specific options configurable through Windows Group Policy templates
[Rewards 3.0] Fix Default AC amount display
* AI Chat: display line breaks in human messages - use white-space: pre-wrap to preserve indentations - add indentation example
…ter tx is confirmed (brave#25957)
[Toggle]: Fix toggles not toggling
…into chrome-130
…into nikhil/chrome-130
android chromium-130 changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.